Change jsxImportSource to react #2184
Merged
+91
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d2e373a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## next #2184 +/- ##
==========================================
- Coverage 96.57% 96.56% -0.02%
==========================================
Files 259 259
Lines 20481 20523 +42
Branches 1938 1928 -10
==========================================
+ Hits 19780 19818 +38
- Misses 693 702 +9
+ Partials 8 3 -5
|
connor-baer
force-pushed
the
fix/jsx-import-source
branch
from
247b0ae
to
79e4fdf
Compare
connor-baer
force-pushed
the
fix/jsx-import-source
branch
from
79e4fdf
to
d2e373a
Compare
tareqlol
approved these changes
Jul 14, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2163.
Purpose
Emotion.js is still included in the bundle for stable components because it is configured as the
jsxImportSource.Approach and changes
jsxImportSourcefrom@emotion/reacttoreactand added a compiler directive override to all files that still use Emotion.jsDefinition of done